Find the Bug in my Fizz Buzz Interview (2:47 video)(edweissman.com)
edweissman.com
Find the Bug in my Fizz Buzz Interview (2:47 video)
http://edweissman.com/find-the-bug-in-my-fizz-buzz-interview
16 comments
Shouldn't he check the divisibility by both 3 AND 5 first?
No, in that case the first two conditionals will both pass and the result will end up as "FizzBuzz".
Well, that would depend on the print statement. Generally, all of them have new lines. Even if they don't you would have to generate new lines appropriately otherwise the next number would print right next to Fizz.
PS : My assumption is that you need to print each number or Fizz or Buzz or FizzBuzz in a separate line.
PS : My assumption is that you need to print each number or Fizz or Buzz or FizzBuzz in a separate line.
Well, you can check for 3 AND 5 first (or check for 15 altogether). This is if you have two subsequent checks for 3 and for 5.
[deleted]
Hahaha genius. "...What??" Oh, and I have no idea what the bug is.
You're checking for a null local variable value in the third conditional, but appending to that same variable in the first two, which would either cause a runtime error in most languages or never pass the third conditional.
In Ruby, for example, you could append a string to nil by interpolating the nil into a string literal, or various other ways. Seeing as he didn't specify the language, what the variable was initialized to, or what exactly "append" means, we can only assume that these imaginary things behave as intended.
It might have been when he initialized the variable result.
He goes on to append strings to this variable which would lead me to believe it has some value that you can append to.
This would make the third conditional where he checks for null to fail, he should check for an empty string.
He goes on to append strings to this variable which would lead me to believe it has some value that you can append to.
This would make the third conditional where he checks for null to fail, he should check for an empty string.
This is my conclusion as well. To wit, an approximate translation of his method into Ruby:
fizzbuzz = (1..100).to_a.map do |i|
result = "" # 1:23 initialize a variable
result += "Fizz" if i % 3 == 0
result += "Buzz" if i % 5 == 0
result = i.to_s if result.nil?
result
end
The bug in the interview is not having a whiteboard or paper or a computer that the interviewee can use.
Forcing anyone to do a coding exercise in their head is ridiculous.
Forcing anyone to do a coding exercise in their head is ridiculous.
That video is so fucking annoying. Why not just show a page with the fucking text?
I see paper and pen/pencil in that office...
He doesn't ever print out result either
He doesn't ever print out result either