Also, "getRequiredSampleSize" is called twice for each variant - in the "getResult"'s loop and then inside "hasEnoughData". Same thing for "getVariant". Would you welcome a pull request?
Your project is great, I'd totally use at work. Also, it was to learn the math behind that. Thanks!
Do I understand correctly that your stable 'master' branch is always ready for release? Basically it means that changes (fixes) should be relatively small, otherwise they are released via channels, correct?
Absolutely. Once you hit the wall trying to solve a problem, you better distance yourself from that problem. Otherwise you'll likely be hitting the same wall over and over again.
For me personally, quiet walk probably won't cut it, because I'd still be focusing on that same solution that failed. But switching my mind completely often helps me to stumble upon a fresh way to solve my problem that will likely work.
I'd say methods should be small enough so that their intent is clear. Usually it means that methods should have exactly one responsibility, otherwise they seem bloated.
I wonder if the guys are doing code reviews for each PR along with making sure build is green. In our team, we've been doing code reviews for about three years now and can't imagine our workflow without them.
I haven't written any C for years, but really enjoyed skimming through Redis codebase, it's so clean, easily understandable and extensible.